Skip to content

[Ecosystem Portal] Fix: WalletConnect Connection #5438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

[Ecosystem Portal] Fix: WalletConnect Connection #5438

merged 1 commit into from
Nov 18, 2024

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Nov 15, 2024 •
edited by pr-codex bot
Loading

CNCT-2258

PR-Codex overview

This PR primarily focuses on enhancing the wallet-ui application by introducing multi-tenant support, refactoring components, and improving code organization. It also updates configurations and dependencies for better performance and maintainability.

Detailed summary

  • Removed erc20.ts and Erc20Token.ts files.
  • Added multi-tenant support via isMultiTenant utility.
  • Updated routing to include ecosystem ID in redirects.
  • Refactored image handling to use Image component.
  • Improved ESLint configurations and added rules.
  • Modified environment variables in .env.example.
  • Enhanced README with ecosystem portal information.
  • Updated postcss and biome configurations.
  • Adjusted useRouter hook for multi-tenant routing.
  • Improved accessibility in image components.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Nov 15, 2024

CNCT-2258 Ecosystem Wallet Page Connection Issue

@vercel
Copy link

vercel bot commented Nov 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 7:21pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 7:21pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 7:21pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 7:21pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.52%. Comparing base (565dbb9) to head (8e22cf8).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5438   +/-   ##
=======================================
  Coverage   45.52%   45.52%           
=======================================
  Files        1070     1070           
  Lines       55707    55707           
  Branches     4031     4031           
=======================================
+ Hits        25360    25361    +1     
+ Misses      29660    29659    -1     
  Partials      687      687
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 565dbb9
packages 40.63% <ø> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.13 KB (0%) 903 ms (0%) 507 ms (+107.78% 🔺) 1.5 s
thirdweb (cjs) 105.15 KB (0%) 2.2 s (0%) 706 ms (+36.95% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 216 ms (+662.15% 🔺) 331 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 26 ms (+502.84% 🔺) 36 ms
thirdweb/react (minimal + tree-shaking) 18.79 KB (0%) 376 ms (0%) 73 ms (+8.96% 🔺) 448 ms

@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8e22cf8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security
Copy link

socket-security bot commented Nov 15, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment Transitive: filesystem +1 40.5 kB ai

🚮 Removed packages: npm/@radix-ui/[email protected]

View full report↗︎

@gregfromstl gregfromstl self-assigned this Nov 15, 2024
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 23:18 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 23:18 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 15, 2024 23:18 Inactive
@gregfromstl gregfromstl added the Ecosystem Portal Involves changes to the Ecosystem Portal label Nov 15, 2024
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 23:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 15, 2024 23:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 23:33 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 23:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 15, 2024 23:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 23:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 16, 2024 00:01 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 16, 2024 00:01 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 16, 2024 00:01 Inactive
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 18, 2024
@gregfromstl Graphite App
Copy link
Contributor Author

gregfromstl commented Nov 18, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 18, 2:06 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 18, 2:16 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 18, 2:20 PM EST: A user merged this pull request with the Graphite merge queue.

@gregfromstl
[Ecosystem Portal] Fix: WalletConnect Connection (#5438)
8e22cf8 
CNCT-2258

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `wallet-ui` application, introducing multi-tenancy support, updating configurations, and improving code quality with better imports and utility functions.

### Detailed summary
- Removed unused files: `erc20.ts`, `Erc20Token.ts`
- Added `isMultiTenant` utility for environment checks
- Updated `README.md` for ecosystem portal
- Enhanced routing with ecosystem ID in redirects
- Introduced new configuration files for `knip` and `biome`
- Updated ESLint rules and configurations
- Refactored image handling to use a new `Image` component
- Streamlined various imports across components and hooks

> The following files were skipped due to too many changes: `pnpm-lock.yaml`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the greg/cnct-2258-ecosystem-wallet-page-connection-issue branch from 83ebcb5 to 8e22cf8 Compare November 18, 2024 19:17
@graphite-app graphite-app bot merged commit 8e22cf8 into main Nov 18, 2024
30 of 31 checks passed
@graphite-app graphite-app bot deleted the greg/cnct-2258-ecosystem-wallet-page-connection-issue branch November 18, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

@jnsdls jnsdls Awaiting requested review from jnsdls jnsdls is a code owner

@MananTank MananTank Awaiting requested review from MananTank

@edwardysun edwardysun Awaiting requested review from edwardysun

Assignees

@gregfromstl gregfromstl

Labels

Ecosystem Portal Involves changes to the Ecosystem Portal merge-queue Adds the pull request to Graphite's merge queue. packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gregfromstl @joaquim-verges